请老师看一下我的代码思路有没有问题

function address(){

    /*请在此补充代码*/

    var province = document.getElementById("province");

    var city     = document.getElementById("city");

    var dz = ["北京","天津","河北","河南"];

    var cdz = ["朝阳","西城","石家庄","邯郸","西城","武庆","郑州","开封"];

    selectAdd(province,dz,dz.length);

    selectAdd(city,cdz,cdz.length);

}

function selectAdd(obj,name,value){

/*请在此补充代码*/  

for(var i=0;i<value;i++){

obj.options.add(new Option(name[i],name[i]));

}

}